fix: map uv to correct semver definition#6719
Open
thomasschafer wants to merge 2 commits intomainfrom
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
58bfe80 to
d270b12
Compare
d270b12 to
cbf5cac
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
d0374d5 to
4e0f9f5
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR makes use of the fix here to map to the correct semver definition for uv. This resolves an issue with testing SBOMs generated directly by uv (it does not affect SBOMs of uv projects generated by
snyk sbom).I also had to update
fake-server.ts. Extensions using a localhost API URL (e.g. os-flows/sbom) have it canonicalised by go-application-framework, stripping the/apiprefix, so they call/hidden/orgs/.... Extensions using a non-localhost IP (e.g. aibom) skip canonicalisation and call/api/hidden/orgs/.... The fix registers theupload_revisionshandlers for both prefixes, and updates response bodies to use dynamic path params rather than hardcoded UUIDs.Finally, I also added an override for
axiosto address https://security.snyk.io/vuln/SNYK-JS-AXIOS-15965856.How should this be manually tested?
Generate an SBOM for a uv project using
then test it using
snyk sbom test --file=sbom.jsonOn main you should see an error like the following:
but on this branch you should see a successful run.
What's the product update that needs to be communicated to CLI users?
None