add a new lint for preferring throw over return ThrowCompletion(...)#692
Open
michaelficarra wants to merge 1 commit intomainfrom
Open
add a new lint for preferring throw over return ThrowCompletion(...)#692michaelficarra wants to merge 1 commit intomainfrom
throw over return ThrowCompletion(...)#692michaelficarra wants to merge 1 commit intomainfrom
Conversation
c8c3b07 to
0d259cc
Compare
bakkot
reviewed
Apr 10, 2026
| ); | ||
| const baseOffset = step.contents[0].location.start.offset; | ||
|
|
||
| walkExpr(expr => { |
Member
There was a problem hiding this comment.
You don't need walkExpr for this; you only really need that when descending recursively into expressions. Here return ThrowCompletion(...) can only appear at the top level (i.e., not within another expression).
Instead you can just walk over stepSeq directly, looking for text nodes ending in return followed by call ThrowCompletion nodes instead of reading the raw source, which is also better because parsed source accounts for <ins> and <del> and etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I used AI in the process of creating this PR.