Conversation
[dev] [Marfuen] mariano/fix-policy-publish-notifications
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…lure (#2591) The Trigger.dev deploy pipeline cannot resolve @trycompai/auth because its dist is not built during the CI deploy step. Remove the transitive dependency by inlining the compliance-obligation filter directly in the helpers file, keeping identical behaviour. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Requires human review: This PR modifies core business logic for policy signatures and introduces a new daily automated email digest task, which requires human verification of compliance impact and notification logic.
Contributor
|
🎉 This PR is included in version 3.23.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Adds a daily policy acknowledgment digest that emails compliance-required members about their pending policies, with batching and unsubscribe support. Also fixes publish logic to only reset signatures on a first-time publish, filters members to notify, and inlines the digest’s compliance filter to avoid a Trigger.dev bundling issue.
New Features
policy-acknowledgment-digest(daily at 14:00 UTC via@trigger.dev/sdk) sends one email per member per org with pending policies.PolicyAcknowledgmentDigestEmailtemplate from@trycompai/email.policyNotificationsusing a newgetUnsubscribedEmailsbatch query.Bug Fixes
PoliciesService.updateById: only clearsignedByand setlastPublishedAtwhen transitioning topublished(no-op if already published).publishAll: clearssignedByfor newly published policies and returns only compliance-obligated members for notifications.Written for commit cee8ed4. Summary will update on new commits.