You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that removing the json+struct C code from tskit itself and providing an example in the C docs is probably the way to go. @bhaller provided the C code, modified from the method and tests in #3437.
Currently this has the additional docs that are also in #3440.
❌ Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.68%. Comparing base (2f26dc6) to head (c5c9157). ⚠️ Report is 4 commits behind head on main.
Codecov is complaining because the example C file is not being hit. AFAICT this is expected, and perhaps we should change this line to ask codecov to just cover c/tskit/ instead of c/?
Merging this since it's been reviewed carefully by Ben H, after consulting with Jerome. I need to double-check the change to .codecov.yml hasn't messed something up; will do that in a separate PR.
I've checked in #3446 that the change to .codecov.yml didn't break codecov's c coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that removing the json+struct C code from tskit itself and providing an example in the C docs is probably the way to go. @bhaller provided the C code, modified from the method and tests in #3437.
Currently this has the additional docs that are also in #3440.