date: fix strftime O/E modifier parsing in C locale#11802
Open
Jah-yee wants to merge 1 commit intouutils:mainfrom
Open
date: fix strftime O/E modifier parsing in C locale#11802Jah-yee wants to merge 1 commit intouutils:mainfrom
Jah-yee wants to merge 1 commit intouutils:mainfrom
Conversation
In C locale, the O (alternative numeric symbols) and E (alternative format) modifiers should be ignored/stripped. However, they were being passed through as literal text because they weren't recognized as flags. This fix adds O and E to the recognized flag characters in parse_format_spec(), so they're properly handled as modifiers and stripped in C locale (as expected by GNU date). Fixes: uutils#11656
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Thank you for your work on this project. I hope this small fix is helpful.
Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof