Add negative test case for CheckPasswordHashUnix#914
Open
padelsbach wants to merge 1 commit intowolfSSL:masterfrom
Open
Add negative test case for CheckPasswordHashUnix#914padelsbach wants to merge 1 commit intowolfSSL:masterfrom
padelsbach wants to merge 1 commit intowolfSSL:masterfrom
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #914
Scan targets checked: wolfssh-bugs, wolfssh-compliance, wolfssh-defaults, wolfssh-mutation, wolfssh-proptest, wolfssh-src, wolfssh-zeroize
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a targeted negative-path unit test for Unix password hash checking to prevent regressions in the constant-time comparison logic.
Changes:
- Introduces a new unit test
test_CheckPasswordHashUnix()that validates both acceptance and rejection paths usingcrypt(). - Exposes
CheckPasswordHashUnix()for unit tests viaWOLFSSHD_UNIT_TESTand moves auth success/failure constants toauth.h.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/wolfsshd/test/test_configuration.c | Adds a new negative-path unit test for Unix password hash verification and required includes/feature macros. |
| apps/wolfsshd/auth.h | Exposes auth result constants and declares CheckPasswordHashUnix() for unit tests. |
| apps/wolfsshd/auth.c | Makes CheckPasswordHashUnix() non-static under WOLFSSHD_UNIT_TEST so the test can link to it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
afcda8b to
6d31d73
Compare
ejohnstown
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-2489