Add xsimd::get<>() for optimized compile-time element extraction#1294
Open
DiamonDinoia wants to merge 2 commits intoxtensor-stack:masterfrom
Open
Add xsimd::get<>() for optimized compile-time element extraction#1294DiamonDinoia wants to merge 2 commits intoxtensor-stack:masterfrom
DiamonDinoia wants to merge 2 commits intoxtensor-stack:masterfrom
Conversation
DiamonDinoia
force-pushed
the
feat/optimize-elem-extraction
branch
from
b7725d8 to
0b6d85f
Compare
Add a free function xsimd::get<I>(batch) API mirroring std::get<I>(tuple) for fast compile-time element extraction from SIMD batches. Per-architecture optimized kernel::get overloads using the fastest available intrinsics: - SSE2: shuffle/shift + scalar convert - SSE4.1: pextrd/pextrq/pextrb/pextrw, bitcast + pextrd for float - AVX: vextractf128/vextracti128 + SSE4.1 delegate - AVX-512: vextracti64x4/vextractf32x4 + AVX delegate - NEON: vgetq_lane_* (single instruction for all types) - NEON64: vgetq_lane_f64 Also fixes a latent bug in the common fallback for complex batch compile-time get (wrong buffer type).
DiamonDinoia
force-pushed
the
feat/optimize-elem-extraction
branch
from
0b6d85f to
c6dd311
Compare
RVV only had runtime get(batch, size_t, requires_arch<rvv>) which became ambiguous with the new compile-time get(batch, index<I>, requires_arch<common>) because index<I> (std::integral_constant) implicitly converts to size_t. Add index<I> overloads that delegate to the runtime versions, matching the pattern used by SSE/AVX/NEON.
Contributor
Author
|
Nice thanks for fixing CI! This is ready for review. Once approved I will rewrite the history. I don't want to trigger a useless CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a free function xsimd::get(batch) API mirroring std::get(tuple) for fast compile-time element extraction from SIMD batches.
Per-architecture optimized kernel::get overloads using the fastest available intrinsics:
Also fixes a latent bug in the common fallback for complex batch compile-time get (wrong buffer type).